Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give CRD policy precedence over skipCRDs field #261

Merged
merged 1 commit into from
May 10, 2021

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented May 10, 2021

This gives the in the previous MINOR release introduced CRD policy
precedence, avoiding skipCRDs is set to false and crds is set to Skip errors when the skipCRDs field is omitted.

Fixes #260
Follow up #250

This gives the in the previous MINOR release introduced CRD policy
precedence, avoiding `skipCRDs is set to false and crds is set to
Skip` errors when the `skipCRDs` field is omitted.

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco added bug Something isn't working area/helm Helm related issues and pull requests labels May 10, 2021
@hiddeco hiddeco force-pushed the helm-install-skip-crd-fix branch from f34581a to d832b35 Compare May 10, 2021 12:03
@hiddeco hiddeco requested a review from stefanprodan May 10, 2021 12:04
@hiddeco hiddeco merged commit e79781e into main May 10, 2021
@hiddeco hiddeco deleted the helm-install-skip-crd-fix branch May 10, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"skipCRDs is set to false and crds is set to Skip"
2 participants